laravel / octane

Supercharge your Laravel application's performance.
https://laravel.com/docs/octane
MIT License
3.78k stars 296 forks source link

Watching For File Changes Server Reloading Crash #105

Closed bdlogicalerror closed 3 years ago

bdlogicalerror commented 3 years ago

Description:

After changes any file Server Crash And Too few arguments to function Laravel\Octane\RoadRunner\ServerProcessInspector::reloadServer(), 0 passed

i figure out the solution octane/src/Commands/Concerns/InteractsWithServers.php on line 54 need to pass any slug.

` while ($server->isRunning()) { $this->writeServerOutput($server);

            if ($watcher->isRunning() &&
                $watcher->getIncrementalOutput()) {
                $this->info('Application change detected. Restarting workers…');

                $inspector->reloadServer('/');
            }

            usleep(500 * 1000);
        }`

Steps To Reproduce:

driesvints commented 3 years ago

Let's see how the pr goes

barryvdh commented 3 years ago

Can you test https://github.com/laravel/octane/pull/177 ?