search

laravel / octane

Supercharge your Laravel application's performance.
https://laravel.com/docs/octane
MIT License
3.78k stars 296 forks source link

Call to a member function status() on bool in EnsureRequestsDontExceedMaxExecutionTime #588

Closed ibrunotome closed 2 years ago

ibrunotome commented 2 years ago

Description:

Screen Shot 2022-09-28 at 18 33 00

this line https://github.com/laravel/octane/blob/1.x/src/Swoole/Actions/EnsureRequestsDontExceedMaxExecutionTime.php#L33

is returning a bool instead of a http response

Steps To Reproduce:

Make a request longer than config max_execution_time

driesvints commented 2 years ago

Can you send in a PR?

ibrunotome commented 2 years ago

Can you send in a PR?

Sure, What behavior do you want that I implement when $response = Response::create($this->server, $row['fd']); returns a bool?

driesvints commented 2 years ago

@nunomaduro do you know?

ibrunotome commented 2 years ago

This is the exact same issue https://github.com/laravel/octane/issues/545 opened 3 months ago and closed because "it is a support request" 🤔

But I'm happy that it's fixed now.

driesvints commented 2 years ago

It was not clear to me that this was a bug at that time. Your report here was more insightful.