laravel / octane

Supercharge your Laravel application's performance.
https://laravel.com/docs/octane
MIT License
3.78k stars 296 forks source link

Workers crashing on 1.5.2 #674

Closed damiantw closed 1 year ago

damiantw commented 1 year ago

Description:

The latest Octane release seems to have a regression related to https://github.com/laravel/octane/commit/7fecb1dcc4cdac60273994b2d831c9a9524940ca.

Workers crash after serving an initial request. Workers stop crashing when I take any of the following actions.

  1. Downgrade to Octane 1.5.1
  2. Remove 'session' and 'session.store' from the octane.warm configuration
  3. Remove \Laravel\Octane\Listeners\GiveNewApplicationInstanceToSessionManager::class as a RequestReceived listener

I'm having trouble finding any useful error output from my local environment (nothing is written to the Laravel log). However, after deploying 1.5.2 to the Vapor environment our logs filled w/ error messages like the following.

{
  "exception": {
    "class": "Illuminate\\Contracts\\Container\\BindingResolutionException",
    "message": "Target class [config] does not exist.",
    "code": 0,
    "file": "/var/task/vendor/laravel/framework/src/Illuminate/Container/Container.php:916",
    "previous": {
      "class": "ReflectionException",
      "message": "Class \"config\" does not exist",
      "code": -1,
      "file": "/var/task/vendor/laravel/framework/src/Illuminate/Container/Container.php:914"
    }
  }
}

Steps To Reproduce:

Octane 1.5.2

Screenshot 2023-04-04 at 2 13 18 PM

Octane 1.5.1

Screenshot 2023-04-04 at 2 15 44 PM
nunomaduro commented 1 year ago

Fixed on 1.5.3.

taylorotwell commented 1 year ago

Also need Laravel framework 10.6.1 FYI.