laravel / octane

Supercharge your Laravel application's performance.
https://laravel.com/docs/octane
MIT License
3.74k stars 291 forks source link

Add octane.roadrunner.config_version settings to roadrunner start binary #822

Closed ValikoDorodnov closed 7 months ago

ValikoDorodnov commented 7 months ago

For more comfortable developing i add an opportunity to set RoadRunner version via config.

UPD

Also add:

taylorotwell commented 7 months ago

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

ValikoDorodnov commented 7 months ago

@taylorotwell Thank you for your feedback, Taylor!

For this implementation, I used the same approach that is used on line

src/Commands/StartRoadRunnerCommand.php:88

The function config() is standard for the Laravel library.

I think developers need to give the ability to manage parameters:

I checked the build functionality, and it seems to be in order.