laravel / octane

Supercharge your Laravel application's performance.
https://laravel.com/docs/octane
MIT License
3.73k stars 289 forks source link

Misleading error if port is already in use #839

Closed ingria closed 5 months ago

ingria commented 5 months ago

Octane Version

2.3.3

Laravel Version

10.45

PHP Version

8.3.3

What server type are you using?

Swoole

Server Version

5.1.1

Database Driver & Version

No response

Description

octane:start command throws a misleading error when using inappropriate port (e.g. when the port is already in use):

php8.3 artisan octane:start --server=swoole

   INFO  Server running…

  Local: http://127.0.0.1:8000 

  Press Ctrl+C to stop the server

PHP Fatal error:  Uncaught Error: Class "Laravel\Octane\Octane" not found in /home/telegram/api/vendor/laravel/octane/src/Stream.php:56
Stack trace:
#0 /home/telegram/api/vendor/laravel/octane/bin/createSwooleServer.php(19): Laravel\Octane\Stream::shutdown()
#1 /home/telegram/api/vendor/laravel/octane/bin/swoole-server(35): require('...')
#2 {main}
  thrown in /home/telegram/api/vendor/laravel/octane/src/Stream.php on line 56
Fatal error: Uncaught Error: Class "Laravel\Octane\Octane" not found in /home/telegram/api/vendor/laravel/octane/src/Stream.php:56

Steps To Reproduce

execute octane:start --port=INVALID_PORT

driesvints commented 5 months ago

We'd appreciate a PR to make this better 👍