search

laravel / octane

Supercharge your Laravel application's performance.
https://laravel.com/docs/octane
MIT License
3.73k stars 289 forks source link

Ensure HTTP server port is available #852

Closed smortexa closed 4 months ago

smortexa commented 4 months ago

Fixes #839

nunomaduro commented 4 months ago

@taylorotwell Ready now.

smortexa commented 4 months ago

@nunomaduro Now, for FrankenPHP, the port checking is only performed when the host is set to 127.0.0.1. Is there a specific reason for this? https://github.com/laravel/octane/blob/14a0ecafa81a7cb7f7363a15f0ac423ac05b1173/src/Commands/StartFrankenPhpCommand.php#L126

nunomaduro commented 4 months ago

Yes. Because you may use FrankenPHP without the tradicional NGINX setup, where that particular check, not on the host 127.0.0.1 will fail.