search

laravel / octane

Supercharge your Laravel application's performance.
https://laravel.com/docs/octane
MIT License
3.73k stars 289 forks source link

Add failing test for UrlGenerator warming up issue #869

Closed gazzoy closed 3 months ago

gazzoy commented 3 months ago

This aims to add failing test for https://github.com/laravel/octane/issues/809. To recap, the issue is when using Route::bind() and URL::defaults() with Octane, it seems that UrlGenerator keeps the same instance of RouteUrlGenerator, and so the defaults are cached between requests.

There is another problem in this test which I got Route [login] not defined. It doesn't really make sense to me since I put ->name('login') in route definition, but I might be wrong.

Please let me know if you have any questions.

taylorotwell commented 3 months ago

We don't merge failing tests. There is no action to take here. We accept fixes via PRs.