search

laravel / octane

Supercharge your Laravel application's performance.
https://laravel.com/docs/octane
MIT License
3.71k stars 284 forks source link

UrlGenerator Sandbox #896

Closed dbpolito closed 1 month ago

dbpolito commented 1 month ago

Currently we're sending the same instance of URL across all requests, when changing defaults or forceRootUrl, the change is happening across all requests...

This should also fix https://github.com/laravel/octane/issues/809

taylorotwell commented 1 month ago

I wonder if this would be a breaking change, especially around the defaults stuff. If someone set a default for localization purposes for example and it was lost on subsequent requests it seems like that could be a problem?

dbpolito commented 1 month ago

Well it may depend on where you call it... But if you call it on on middleware where it's recommended it shouldn't have any impact as in theory you will always be setting it...

But tbh, i think the potential problems we currently have is probably bigger than the people that may be impacted (which is very minimum i think)... 🤔