search

laravel / octane

Supercharge your Laravel application's performance.
https://laravel.com/docs/octane
MIT License
3.71k stars 284 forks source link

Refreshes log manager container #910

Closed timacdonald closed 3 weeks ago

timacdonald commented 3 weeks ago

This PR ensures that the log manager gets its container refreshed. Context is not being appended to log files as expected due to the stale container.

This is required because we do not eagerly resolve context from the container, so the parent container will never a context repository instance resolved (they belong to the sandbox application).

https://github.com/laravel/framework/blob/02a0b5f6f83b13ea750f959364aefa324441a354/src/Illuminate/Log/LogManager.php#L142-L149

fixes https://github.com/laravel/octane/issues/907

driesvints commented 3 weeks ago

Drafting this until we can fix the tests.