search

laravel / octane

Supercharge your Laravel application's performance.
https://laravel.com/docs/octane
MIT License
3.71k stars 284 forks source link

[2.x] Add `laravel/prompts`. #917

Closed xiCO2k closed 3 weeks ago

xiCO2k commented 3 weeks ago

This PR utilizes the laravel/prompts to improve mostly the $this->choice and the $this->confirm prompts.

Also change the info, warn and error to use the $this->components version.

Before:

https://github.com/laravel/octane/assets/823088/08d739d1-4e35-4e2a-9cea-c99056da018a

After:

https://github.com/laravel/octane/assets/823088/3a88d9ab-5660-4fae-94ac-4ba504ee490e

Cheers

crynobone commented 2 weeks ago

@xiCO2k There seem to be a regression based on this PR #918

xiCO2k commented 2 weeks ago

Will take a look on that @crynobone

driesvints commented 2 weeks ago

@xiCO2k did you figure this one out? Otherwise it might be best if we revert for now.

xiCO2k commented 1 week ago

Hey @driesvints did not had the time to check it, will try to look during the weekend.

Thanks.

xiCO2k commented 1 week ago

@driesvints PR #920 .