laravel / octane

Supercharge your Laravel application's performance.
https://laravel.com/docs/octane
MIT License
3.77k stars 296 forks source link

Added the ability to set RoadRunner and FrankenPhp binary file path via config #925

Closed mingalevme closed 3 months ago

mingalevme commented 3 months ago

Added the ability to set rr/frankenphp binary file via config and/or env var:

config/octane.php:

<?php

// ...

return [
    //...

    /*
    |--------------------------------------------------------------------------
    | RoadRunner
    |--------------------------------------------------------------------------
    |
    */

    'roadrunner' => [
        'binary' => env('OCTANE_ROADRUNNER_BINARY'),
    ],

    /*
    |--------------------------------------------------------------------------
    | FrankenPHP
    |--------------------------------------------------------------------------
    |
    */

    'frankenphp' => [
        'binary' => env('OCTANE_FRANKENPHP_BINARY'),
    ],
];
taylorotwell commented 3 months ago

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!