search

laravel / octane

Supercharge your Laravel application's performance.
https://laravel.com/docs/octane
MIT License
3.74k stars 291 forks source link

Missing config option for swoole server set? #98

Closed viezel closed 3 years ago

viezel commented 3 years ago

When looking at https://github.com/laravel/octane/blob/master/bin/createSwooleServer.php#L20

Then are we not missing the following in the octane config? 

'swoole' => [
    'options' => [
         // see https://www.swoole.co.uk/docs/modules/swoole-server/configuration
    ],
],

It would be great to be able to pass config to the swoole server set feature from the config/octane.php.

jihadismail8 commented 3 years ago

i agree !! i do not know why during swoole installation i answered all the questions by NO ( json , coroutine ..etc support ) but yet when i check up the configs of swoole i find out that coroutines are enabled . so this kind of enhancement would be really useful

sy-records commented 3 years ago

@jihadismail8 Swoole's coroutine support is enabled by default, No option during installation

You can turn it off via php.ini

swoole.enable_coroutine=Off
taylorotwell commented 3 years ago

For now I'm keeping the config clean but may add this later. You can add it to your own configuration file if you wish.