laravel / passport

Laravel Passport provides OAuth2 server support to Laravel.
https://laravel.com/docs/passport
MIT License
3.29k stars 780 forks source link

[11.x] Removed deprecated `dates` property from `AuthCode` model #1644

Closed siarheipashkevich closed 1 year ago

siarheipashkevich commented 1 year ago

Use casts instead of dates property.

taylorotwell commented 1 year ago

Not sure we would do this on a patch release? /cc @driesvints

siarheipashkevich commented 1 year ago

https://github.com/laravel/passport/pull/1636

On the Laravel 10 it will break application if I use expires_at and expect that this field is carbon instance.

@taylorotwell @driesvints

siarheipashkevich commented 1 year ago

@driesvints could you check this PR please?

driesvints commented 1 year ago

I think this is fine tbh. I really doubt people are overwriting this directly.