laravel / passport

Laravel Passport provides OAuth2 server support to Laravel.
https://laravel.com/docs/passport
MIT License
3.28k stars 776 forks source link

Some tables does not meet Laravel standards #1685

Closed nastoychev closed 1 year ago

nastoychev commented 1 year ago

In whole Laravel Ecosystem the tables start with id of type bigIncrements and have by default timestamps. Here this convention is not followed. The problem what I have is reduced combability with Laravel Nova beacuse the action_events table does not support id of type varchar(100).

The tables are:

In my opinion, the problem applies both to this project and to a Laravel/Nova one that does not allow support for other types of Ids.

crynobone commented 1 year ago

In my opinion, the problem applies both to this project and to a Laravel/Nova one that does not allow support for other types of Ids.

Where exactly in Laravel Nova does it say you can only use auto increment IDs.

The only limitations is via Action Events but I don't believe you have any requirements to edit or run actions on those tables.

driesvints commented 1 year ago

Welcoming PRs, thanks.