search

laravel / passport

Laravel Passport provides OAuth2 server support to Laravel.
https://laravel.com/docs/passport
MIT License
3.25k stars 780 forks source link

New major version required for league/oauth2-server 9 #1748

Open TomHAnderson opened 1 month ago

TomHAnderson commented 1 month ago

I'm sure other people have reasons to see the upgrade too. Here's mine:

league/oauth2-server 8.x uses league/event 2.2 but league/event 3.0.x has been out for some time. My library https://doctrine-orm-graphql.apiskeletons.dev/en/latest/ had to degrade from 3.0.x to 2.2 as a new major version because https://ldog.apiskeletons.dev/ needs an OAuth2 library and since the LDOG Stack is rooted in Laravel, you folks have the best thing going.

To keep this library as relevant as ever, I'm requesting you begin work for support of league/oauth2-server 9

Sephster commented 1 month ago

There is an open bug in v9 which I'm hoping to fix early next week. It would be best to get this into passport before a new major is tagged

driesvints commented 1 month ago

Hey @TomHAnderson! We have a fully working version ready to go on the 13.x branch which is pending release. But before we do that there's a couple of things we still want to address. @hafezdivandari is looking into this. A few PR's are still pending a review from Taylor which atm also has quite a few other things going on. I'm also hoping we can release a new major version soon but for now we'll have to have a bit more patience.

@Sephster that's cool. Feel free to ping me here when that's done. Thanks for all your work on oauth server 🙏

hafezdivandari commented 1 month ago

@Sephster actually 2 bugs, that I've previously sent 2 PRs to address them:

And also 2 more PRs which would be really appreciated if we can merge before major Passport release:

hafezdivandari commented 1 week ago

Hi @Sephster, I was wondering if you had any availability to review these 2 PRs I've sent?

saade commented 1 week ago

Sad to not see Token Introspection in v9 :(

driesvints commented 1 week ago

@saade what do you mean?

saade commented 1 week ago

@driesvints

575 #491

driesvints commented 1 week ago

@saade as said in those issues, we need OAuth Server to implement this first before we can implement it in Passport. Maybe that's already done? @Sephster

saade commented 1 week ago

Yup, commented on those issues as well, just replied here as @Sephster was aware of this PR :)

Sephster commented 1 week ago

Token introspection isn't in v9. No concrete plans on it yet. Working on fixing bugs raised by @hafezdivandari first and will post here when completed. Thanks