laravel / passport

Laravel Passport provides OAuth2 server support to Laravel.
https://laravel.com/docs/passport
MIT License
3.29k stars 780 forks source link

[13.x] Rename `CheckClientCredentials` middleware #1792

Closed hafezdivandari closed 1 month ago

hafezdivandari commented 1 month ago

This PR corrects the naming of the CheckClientCredentials and CheckClientCredentialsForAnyScope middlewares. As mentioned in this comment and this issue, the current naming is confusing and does not accurately reflect the functionality of these middlewares:

Summary

Usage

Refer to the updated docs:

taylorotwell commented 1 month ago

Isn't the token the client's credentials?

hafezdivandari commented 1 month ago

@taylorotwell No, it works with any token, and that's exactly what makes its naming confusing.

taylorotwell commented 1 month ago

@hafezdivandari it's probably about time we think about releasing 13.x? Is there much more to do?

hafezdivandari commented 1 month ago

@taylorotwell there are 5 PRs in draft, the most important one is #1750 and #1762, we are waiting for @Sephster to merge the related bug fixes on oauth2-server package before Passport 13.x release.