Closed timacdonald closed 2 months ago
Thanks for submitting a PR!
Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.
Pull requests that are abandoned in draft may be closed due to inactivity.
fixes https://github.com/laravel/pennant/issues/106
There is an inconsistency when retrieving a list of specific values with Pennant.
When you have a class-based feature that has a name, e.g,
$name = 'my-feature';
, theFeature::values
function will inconstantly return the name and the feature's classname.Given the following class...
We see the inconsistency in the last call to
Feature::values
:Given the main usecase for the
Feature::values
function is to pass features to the front end......and the main usecase for the
$name
is to decouple the database and front end from the back end implementation, this feels like a bug that we should address.