search

laravel / pint

Laravel Pint is an opinionated PHP code style fixer for minimalists.
https://laravel.com/docs/pint
MIT License
2.75k stars 138 forks source link

[1.x] Bump Dependencies and run Tests on skeleton #240

Closed Jubeki closed 8 months ago

Jubeki commented 8 months ago

Replaces https://github.com/laravel/pint/pull/232

Jubeki commented 8 months ago

@nunomaduro I tested with the available options, but a change in the skeleton would be necessary (or removing the rule fully_qualified_strict_types would also be an option.)

Here the documentation of the rule fully_qualified_strict_types https://cs.symfony.com/doc/rules/import/fully_qualified_strict_types.html

The failing tests are here, because I also added the skeleton to the test workflow.

Jubeki commented 8 months ago

The changes in the skeleton would be regarding the imported middleware in app/Http/Kernel.php due to the namespace of the Middleware being a subnamespace of App\Http.

- \App\Http\Middleware\Authenticate::class,
+ Middleware\Authenticate::class,

See Results/changes here: https://github.com/Jubeki/laravel-code-style/actions/runs/7454679874/job/20282449218