[1.x] Replace custom phpdoc_align rule with php-cs-fixer option

[Jubeki]

• Replaces custom phpdoc_align rule with php-cs-fixer option
• This also adds an additional test case
• Fixes tests, the output for check style is now different:

  <checkstyle version="PHP CS Fixer 3.47.0 Big Changes by Fabien Potencier, Dariusz Ruminski and contributors.">
  <file name="/Users/kiekbjul/Home/opensource/laravel-pint/tests/Fixtures/with-fixable-issues/file.php">
  <error severity="warning" source="PHP-CS-Fixer.new_with_parentheses" message="Found violation(s) of type: new_with_parentheses"/>
  </file>
  </checkstyle>

• format code with the new pint version.

[github-actions[bot]]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

[eusonlito]

php-cs-fixer phpdoc_align docs: https://cs.symfony.com/doc/rules/phpdoc/phpdoc_align.html

[Jubeki]

@eusonlito What exactly is your comment about?

[eusonlito]

@Jubeki after updating to the latest release I got an error The rules contain unknown fixers: "Laravel/laravel_phpdoc_aligment".

I had this rule as false so I leave the link to the php-cs-fixer rule as reference if anyone wants information on how to customize it.

[phh]

Well, since updating from 1.13.8 to 1.13.9 I've been having issues with pint no being able to fix my issues.

sail pint app/Models/ -v

.....!.............!..!.........!.......

  ! app/Models/A.php                                                                      syntax error, unexpected token ">"
  ! app/Models/B.php                                                                       syntax error, unexpected token ">"
  ! app/Models/C.php                                                                      syntax error, unexpected token ">"
  ! app/Models/D.php                                                 syntax error, unexpected token "=", expecting "=>"

An error from one of the files are:

 ! app/Models/A.php                                                                      syntax error, unexpected token ">"
     85▕             get: function () {
     86▕                 $disk = Storage::disk('images');
     87▕
     88▕                 return [
  ➜  89▕                     'logo'     => isset($this->images['logo']) ? $disk->url($this->images['logo']) : null,

Only change I did to my files was to remove the "Laravel/laravel_phpdoc_alignment": false rule from pint.json, since after this PR it no longer exists.

Other who has issues with this?

[Jubeki]

@phh probably something with another php-cs-fixer rule. I will send another PR, which bumps the php-cs-fixer version to the patch which was released.

[Jubeki]

@phh can you send a code snippet, so that I can confirm if the new patch version would work?

[phh]

@Jubeki Could reproduce on a fresh laravel app with:

pint.json:

{
  "preset": "laravel",
  "rules": {
    "binary_operator_spaces": {
      "default": "align_single_space_minimal"
    }
  }
}

app/Models/TestModel.php

<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\Storage;

class TestModel extends Model
{
    public function imageUrls()
    {
        $disk = Storage::disk('test');

        return [
            'a' => $disk->url($this->images['a']),
            'aa' => $disk->url($this->images['aa']),
        ];
    }

    protected function someMethod($items = []): void
    {
        if (count($items) > 0) {}
    }
}