Closed adam-code-labx closed 4 months ago
1.15.1
8.3
"final_class": true, "final_internal_class": false,
Using the following pint rules I would expect classes marked by @internal would be ignored https://laravel-news.com/configuring-laravel-pint#content-final-internal-class
final class FilamentTestCase extends TestCase { protected function getEnvironmentSetUp($app): void { parent::getEnvironmentSetUp($app); } }
PhpStorm for example recognises the @intenal parent
TestCase should not be final as I have added @internal
After formatting with pint it prepends final
Expected behaviour here is final_internal_class should override the final_class rule. Or perhaps I am missing something here?
final_internal_class
final_class
Hi there. This isn't something Pint can help with since it's a PHP CS Fixer behaviour so please report this to their repo, thanks.
Pint Version
1.15.1
PHP Version
8.3
Description
Using the following pint rules I would expect classes marked by @internal would be ignored https://laravel-news.com/configuring-laravel-pint#content-final-internal-class
Steps To Reproduce
PhpStorm for example recognises the @intenal parent![CleanShot 2024-04-17 at 18 23 32@2x](https://github.com/laravel/pint/assets/53559175/372a2a7b-195f-4ef9-b07c-5f6f9df89148)
TestCase should not be final as I have added @internal![CleanShot 2024-04-17 at 18 25 29@2x](https://github.com/laravel/pint/assets/53559175/d7c88289-cba6-4e5b-b866-6c65d47dab10)
After formatting with pint it prepends final![CleanShot 2024-04-17 at 18 26 31@2x](https://github.com/laravel/pint/assets/53559175/0bb855fa-9c3c-4981-86aa-c84b8275d29e)
Expected behaviour here is
final_internal_class
should override thefinal_class
rule. Or perhaps I am missing something here?