A specific php-cs-fixer rule (method_chaining_indentation) not working with pint - Githubissues

laravel / pint

Laravel Pint is an opinionated PHP code style fixer for minimalists.

https://laravel.com/docs/pint

MIT License

2.8k stars 143 forks source link

A specific php-cs-fixer rule (method_chaining_indentation) not working with pint #91

Closed introwit closed 2 years ago

introwit commented 2 years ago

Pint Version: 1.0.0
PHP Version: 8.1.1

Description:

This specific method_chaining_indentation rule is not working when setup via the pint.json config file. It works when using this in the .php-cs-fixer.php file and running the cs fixer directly.

Steps To Reproduce:

I have created a fresh installation of Laravel and pushed the repo to GitHub.
It has both the pint.json file and the .php-cs-fixer.php file as well.
I have added few lines in the Controller here to test this rule. If you have php-cs-fixer setup locally and run it, this is how the before and after looks like. It fixes as expected.

Screenshot 2022-07-25 at 3 27 41 PM

But if I run pint, it does not fix it.

nunomaduro commented 2 years ago

Your JSON file is invalid. Try this:

{
    "rules": {
        "concat_space": {
            "spacing": "one"
        },
        "method_chaining_indentation": true
    }
}

introwit commented 2 years ago

That worked. Thank you :heart: