search

laravel / prompts

Beautiful and user-friendly forms for your command-line PHP applications.
https://laravel.com/docs/prompts
MIT License
532 stars 94 forks source link

Add ability to specify character in pad function #141

Closed ProjektGopher closed 6 months ago

ProjektGopher commented 6 months ago

This PR adds the ability to specify the character used to pad strings in the DrawsBoxes trait. By using a default value of [SPACE] as an optional third parameter, this is fully backward compatible, and the test suite shows that no existing functionality is broken as a result.

This will allow the pad() method to be used with box characters, or whatever else might be needed.

ProjektGopher commented 6 months ago

Marked as draft, but this is ready to go once reviewed.

driesvints commented 6 months ago

@ProjektGopher draft PR's aren't reviewed. Please mark this as ready if you need one.

ProjektGopher commented 6 months ago

Thx @driesvints, I thought marking as draft was part of Larave's process for this repo since my other PR got marked as draft without comment. Thx for the heads-up.