search

laravel / pulse

Laravel Pulse is a real-time application performance monitoring tool and dashboard for your Laravel application.
https://pulse.laravel.com
MIT License
1.43k stars 165 forks source link

[1.x] Fix trimming direct to storage ingest #318

Closed sinnbeck closed 7 months ago

sinnbeck commented 7 months ago

Currently pulse does not actually trim records. This is due to an accidental double clousure call in Pulse::ingest(). It uses both fn() => and $this->trim(...) causing a double closure, which is then called, resulting in trim never getting called.

//before
->winner(fn () => $this->rescue(fn () => $ingest->trim(...)))
//after
->winner(fn () => $this->rescue($ingest->trim(...)))

Reported here. https://github.com/laravel/pulse/issues/317