search

laravel / pulse

Laravel Pulse is a real-time application performance monitoring tool and dashboard for your Laravel application.
https://pulse.laravel.com
MIT License
1.48k stars 173 forks source link

Messed up timezones after PR #417 #422

Closed maciek-szn closed 1 day ago

maciek-szn commented 4 days ago

Pulse Version

1.2.6

Laravel Version

11.33.2

PHP Version

8.3.13

Livewire Version

3.5.12

Database Driver & Version

No response

Description

After #417 timezones are messed up much more than before.

It's 16:56 CET here now.

CPU and memory graphs show UTC time (so 1 hour back): obraz

Queues graph shows CET time (correct): obraz

However queues card title tooltip shows some mystery timezone (1 hour forward, definitely not CET): obraz

Custom cards just use UTC. I'm guessing they should be manually modified by their authors, but do the authors know about it?

Steps To Reproduce

Just observe the Pulse cards.

timacdonald commented 4 days ago

Thanks for raising this one. Looks like the graph update mechanism was missed on this one for the memory and CPU stats, as they slightly vary from the queue implementation.

I've opened a PR to address the wrong formatting after updates: https://github.com/laravel/pulse/pull/423

If custom cards want to format their dates, they will need to manually make this happen. There is a global window.formatDate function available if they wish to use it. But they can also implement their own formatting if they wish.

I'm unable to replicate the issue with the queues card date. If you can provide the steps to reproduce the problem I will reopen the issue and dive into it.

maciek-szn commented 3 days ago

I'm unable to replicate the issue with the queues card date. If you can provide the steps to reproduce the problem I will reopen the issue and dive into it.

There are no specific steps to reproduce. It just works that way. I can describe the server and client configuration.

Server:

Client:

The tooltip issue occurs not only on the Queues card, but on other cards as well.

timacdonald commented 2 days ago

Hmm. Can you please try upgrading to v1.2.7, which we released yesterday, and then running php artisan view:clear and let me know which issues are remaining?

maciek-szn commented 1 day ago

Sure. Unfortunately nothing has changed. It's 20:13 CET here and the tooltip shows 21:13 CET.

obraz

The CPU and Memory graphs work fine in 1.2.7.

timacdonald commented 1 day ago

Appreciate you checking this again.

I've opened a PR to fix this: https://github.com/laravel/pulse/pull/425