Move connection parameters to phpunit env

laravel / reverb

Laravel Reverb provides a real-time WebSocket communication backend for Laravel applications.

https://reverb.laravel.com

MIT License

1.02k stars 71 forks source link

Move connection parameters to phpunit env #132

Closed ArthurPatriot closed 4 months ago

ArthurPatriot commented 4 months ago

Hello guys. What you think about to move all connections parameters to phpunit env. For example, I want to test reverb on windows machine, windows doesn't support creating socket connection on 0.0.0.0, I must use local ip. And now, I must add host parameter to each test where present host...

Will be easy to get this parameters from env ($host, $port, $appId). And code will be more clean and reusable. What you think?

joedixon commented 4 months ago

I think it's nice to have the option to spin up multiple servers on different hosts, but I don't think I'm against defaulting to the phpunit environment.

joedixon commented 4 months ago

Would welcome a PR for this, but closing for now.