search

laravel / reverb

Laravel Reverb provides a real-time WebSocket communication backend for Laravel applications.
https://reverb.laravel.com
MIT License
1.02k stars 71 forks source link

[1.x] Handles Telescope ingest #151

Closed joedixon closed 4 months ago

joedixon commented 4 months ago

This PR resolves #148

Telescope works by stroing events after a response has been sent or a job processed. With Reverb, neither of these things happen so Telescope entries accumulate causing in memory consumption.

This PR attempts to address that by periodically storing and flushing the buffer of entries in a similar approach to Pulse.

maartengithub commented 4 months ago

If you have telescope installed but, as documented, in production you don't load the TelescopeServiceProvider, then reverb fails on this line in script StartServer.php:

\Laravel\Telescope\Telescope::store($this->laravel->make(\Laravel\Telescope\Contracts\EntriesRepository::class));

because EntriesRepository is not bound. Am I missing something here?

joedixon commented 4 months ago

@maartengithub this is a great catch, thank you. Updated here: https://github.com/laravel/reverb/pull/164

maartengithub commented 4 months ago

Thanx. I saw that it was pulled into main branch already. Now I can push my codebase to production:) Have a nice weekend.MaartenVerstuurd vanaf mijn iPadOp 19 apr. 2024 om 16:14 heeft Joe Dixon @.***> het volgende geschreven: @maartengithub this is a great catch, thank you. Updated here: #164

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>