search

laravel / sail

Docker files for running a basic Laravel application.
https://laravel.com/docs/sail
MIT License
1.65k stars 470 forks source link

fresh install laravel 11 using bash don't remove comment from dotenv DB_DATABASE #681

Closed ivenspontes closed 6 months ago

ivenspontes commented 6 months ago

Sail Version

1.29.0

Laravel Version

11.0.3

PHP Version

8.3

Operating System

Linux

OS Version

24.04

Description

When i try to install with curl -s "https://laravel.build/test" | bash In .env changes to # DB_DATABASE=test

but this line https://github.com/laravel/sail/blob/9d143559a2d98a6487b30a3d1bdbb5d02e7b6458/src/Console/Concerns/InteractsWithDockerComposeServices.php#L126

suppose to be # DB_DATABASE=laravel to remove comment

Steps To Reproduce

install laravel with curl -s "https://laravel.build/test" | bash command

driesvints commented 6 months ago

Tried this out. It removed the comment for me.

sotten commented 6 months ago

@driesvints I can also reproduce the reported error under Ubuntu 22.04 from ivenspontes.

driesvints commented 6 months ago

I need a way to reproduce this.

vita10gy commented 6 months ago

Noob here who might just not understand something, but as far as I can tell it also still pulls mysql but then seems to be in no mans land on neither that or the new sqllite-as-default just working out of the box.