laravel / sail

Docker files for running a basic Laravel application.
https://laravel.com/docs/sail
MIT License
1.65k stars 470 forks source link

Revert opcache for CLI #684

Closed driesvints closed 5 months ago

driesvints commented 5 months ago

We've had several issues for installing Jetstream, etc because opcache was caching certain files:

https://github.com/laravel/jetstream/issues/1454 https://github.com/laravel/jetstream/issues/1451 https://github.com/laravel/octane/issues/858

@jessarcher has already worked on a potential fix to invalidate the opcache file before installing the provider: https://github.com/laravel/framework/pull/50665

But I feel like the original PR https://github.com/laravel/sail/pull/569 was a mistake (sorry @lukeraymonddowning!) as it's simply not recommended to have opcache enabled on CLI.

People can still enable this on their own if they want to.