search

laravel / sail

Docker files for running a basic Laravel application.
https://laravel.com/docs/sail
MIT License
1.65k stars 470 forks source link

MariaDB 11 support #698

Closed tomcoonen closed 2 months ago

tomcoonen commented 3 months ago

Since MariaDB 11 differentiates more from MySQL, and to still support v10 I've split them up. While upgrading an app you might need to switch back, and removing the MariaDB volume is extra work. By naming the volumes differently you have no issues there.

taylorotwell commented 3 months ago

So how would the maria11.stub actually get into the user's docker-compose.yml file?

tomcoonen commented 3 months ago

@taylorotwell If you're ok with the approach, I can add the rest of the code? Not sure if we should keep 'mariadb' or change it to 'mariadb10'?

taylorotwell commented 3 months ago

It could potentially be kept separate from Maria 10.

tomcoonen commented 3 months ago

@taylorotwell Made the rest of the changes, tried to keep as much as possible in line with what is already there.

driesvints commented 2 months ago

@tomcoonen don't forget to mark the PR back to ready if you need a review 😉