laravel / sail

Docker files for running a basic Laravel application.
https://laravel.com/docs/sail
MIT License
1.68k stars 476 forks source link

Sail installation fails if the user asks for MariaDB 10 or 11 #702

Closed andrew-downey closed 4 months ago

andrew-downey commented 4 months ago

Sail Version

1.30.0

Laravel Version

11.13.0

PHP Version

8.3

Operating System

Linux

OS Version

6.7.12

Description

Sail fails to install if MariaDB is selected.

It appears that the stub returns mariadb as the service for both mariadb10 and mariadb11, which does not match an array key (which are now suffixed with a version since 1.30.0).

vendor/laravel/sail/src/Console/Concerns/InteractsWithDockerComposeServices.php:90

Steps To Reproduce

php artisan sail:install and select one of the MariaDB options alternatively curl -s "https://laravel.build/example-website?with=mariadb,redis,typesense,minio,mailpit" | bash

kursatcanciger commented 4 months ago

Same error :)

I came up with a solution and created a pull request. I hope it will be helpful.

703