laravel / sail

Docker files for running a basic Laravel application.
https://laravel.com/docs/sail
MIT License
1.65k stars 470 forks source link

Update EXPOSE port command #706

Closed SamuelMwangiW closed 1 month ago

SamuelMwangiW commented 1 month ago

The Dockerfile currently exposes port 80 by default using the following command:

SUPERVISOR_PHP_COMMAND="/usr/bin/php -d variables_order=EGPCS /var/www/html/artisan serve --host=0.0.0.0 --port=80"

It's important to note that the EXPOSE command in Docker does not actively publish ports; rather, it serves as a declaration for applications like traefik to discover which ports are intended to be exposed by the container.

Commit 33a723fa73b7dc66797f343e8cab372ee5531559 removes the 8080 port, as it was not being utilized by any service by default. Feel free to revert this commit if you prefer to maintain the previous port configuration.

I am open to updating the port from EXPOSE 80/tcp to EXPOSE 80 if you would rather the existing format

Thank you for your attention to this matter.