laravel / sail

Docker files for running a basic Laravel application.
https://laravel.com/docs/sail
MIT License
1.65k stars 470 forks source link

[1.x] Only support MariaDB 11 #707

Closed Jubeki closed 1 month ago

Jubeki commented 1 month ago

Reverts https://github.com/laravel/sail/pull/698 and https://github.com/laravel/sail/pull/703 to only one supported MariaDB Version.

Laravel Sail only supports one MySQL version (MySQL 8). The problems which arise with multiple versions of MariaDB, introduce unneeded complexity.

Therefor this PR reverts back to only on supported MariaDB Version, which is now MariaDB 11 instead of MariaDB 10, which it was before the other PRs.

See Issues: https://github.com/laravel/sail/issues/702 and https://github.com/laravel/sail/issues/701

After this is merged and released, I will also revert the changes in the Laravel Sail Server Script: https://github.com/laravel/sail-server/pull/24

How to test the changes:

laravel new sail-test --no-interaction
cd sail-test
composer config repositories.sail vcs https://github.com/Jubeki/laravel-sail.git
composer require laravel/sail:dev-mariadb11 --dev
php artisan sail:install --with=mariadb

vendor/bin/sail up -d --wait
vendor/bin/sail artisan migrate
open http://localhost

Please don't forget to stop the docker container after testing:

vendor/bin/sail down
github-actions[bot] commented 1 month ago

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

Jubeki commented 1 month ago

Seems the problem was my local setup, now no database creation errors happen anymore on my side.