search

laravel / sail

Docker files for running a basic Laravel application.
https://laravel.com/docs/sail
MIT License
1.65k stars 470 forks source link

When adding a service to existing setup it breaks the existing configuration #710

Closed JerryVerhoef closed 1 month ago

JerryVerhoef commented 1 month ago

Sail Version

v1.30.1

Laravel Version

11.14

PHP Version

8.3.6

Operating System

Linux

OS Version

Ubuntu 24.04

Description

When adding the redis service to an existing setup the environment configuration of the existing setup was changed.

For local dev we are using an empty password for connecting to the database after adding an extra service the environment DB_PASSWORD was changed to "DB_PASSWORD=password"

Either we inform the user that the password is changed or we leave it alone. I would prefer the latter, but this is a personal preference. If we want to change it, I am willing to give it a go. But I would prefer that a decision is made on which solution.

Steps To Reproduce

  1. Have an .env file with the database configuration is set
  2. Make sure the "DB_PASSWORD" is empty
  3. Run sail art sail:add redis
  4. Observe the "DB_PASSWORD" in the .env changes
driesvints commented 1 month ago

Hey there,

Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to open up a new issue with a link to the original one and we'll gladly help you out.

Thanks!