Closed DarkGhostHunter closed 3 weeks ago
Thanks for submitting a PR!
Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.
Pull requests that are abandoned in draft may be closed due to inactivity.
Thanks for submitting a PR!
Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.
Pull requests that are abandoned in draft may be closed due to inactivity.
Thanks for noting that, dear bot. The PR is ready for review, so this won't get abandoned.
Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!
What?
This brings Microsoft SQL Server (their latest version) to Sail. I did it because I usually deal with clients using Azure ootb, and MSSQL it's very picky.
Because the Docker Container is very non-standard, the whole setup is done by setting a custom entrypoint. If no command is issued, the script initializes the databases (default and testing) and then starts SQL Server again but through
exec
.EULA shenanigans
The installation is done by manually accepting Microsoft SQL Server EULA, which is found on their Docker Hub. This is both required to install the database engine and the PHP extensions to connect. If the EULA is not accepted, the installation fails.
This sounds like a hurdle, but the correct thing to do is let the developer accept the EULA.
What adds and changes
sqlsrv
service.DB_ROOT_PASWORD
with a complex password (required by SQL Server)sqlsrv
andpdo_sqlsrv
only if the EULA is accepted (by default, nope).Pending work
slqsrv
to the accepted services array.sqlsrv
support with the following caveats: