laravel / sail

Docker files for running a basic Laravel application.
https://laravel.com/docs/sail
MIT License
1.68k stars 475 forks source link

Use selenium/standalone-chromium on ARM #723

Closed Jubeki closed 1 month ago

Jubeki commented 1 month ago

[!NOTE] There are two possible PR: This one here which only modifies the ARM image, or https://github.com/laravel/sail/pull/722 which unifies the chromium image for both AMD and ARM. I would be more in favour of the other PR https://github.com/laravel/sail/pull/722, because in a multi person team, it causes less disruptions if different platforms are used.

Based on the PR https://github.com/laravel/docs/pull/9875 I replaced the image which will be used on ARM, without touching the AMD part.

Description of the PR https://github.com/laravel/docs/pull/9875:

This PR changes the recommended image for Sail's Selenium service on Apple Silicon from seleniarm/standalone-chromium to selenium/standalone-chromium. Notice selenium instead of seleniarm 😄

Reason: The community-maintained fork was merged back into the official Selenium project in May 2024 and is now only maintained there. See the official announcement by the Selenium project. The latest seleniarm/standalone-chromium release is Chromium v124.0.6367.78 from four months ago. Its GitHub repository is now archived. Unfortunately, until Google provides Linux/ARM builds for Chrome, Apple Silicon / ARM users still need to switch from Chrome to Chromium.

github-actions[bot] commented 1 month ago

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.