Closed sjcobb2022 closed 7 months ago
Can you please indeed undo all unrelated style changes? Thanks!
Can you please indeed undo all unrelated style changes? Thanks!
Sure sorry about that
@driesvints reverted changes!
As a note: I have also tested this on a large repo that I have been working on. We use the database driver, and it works perfectly.
Everything works as expected and all my tests for that project also pass.
Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.
Implementation
Implements the changes proposed in #803.
This adds a scopeSearch to rely on laravel's query scopes. I think that this is a really powerful feature, as it allows really flexible queries.
For example:
Sorry about all the annoying file changes, my linter is pretty aggressive. Can be removed if necessary.