search

laravel / scout

Laravel Scout provides a driver based solution to searching your Eloquent models.
https://laravel.com/docs/scout
MIT License
1.54k stars 327 forks source link

[Typesense] Issue when searching with queryCallback #817

Closed karakhanyans closed 5 months ago

karakhanyans commented 5 months ago
taylorotwell commented 5 months ago

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

driesvints commented 5 months ago

Hey @karakhanyans. Sorry, we usually require an explanation when doing PR's (see the PR template when submitting). Let's make sure next time we give Taylor all the info he needs to review a PR. I'll re-open this one for you and let Taylor know this is gtg.

karakhanyans commented 5 months ago

@driesvints Yes, sorry, as this was a bug fix, that's why I haven't written a detailed explanation. Will do next time for sure.