Closed AbdullahFaqeir closed 4 months ago
I'd give much more detailed info here for Taylor to review. Otherwise it won't be clear why this is needed.
But now the method says it returns a Collection in the docblock but actually returns an index?
But now the method says it returns a Collection in the docblock but actually returns an index?
I apologise as this is a mess-naming for the variable, will make sure to fix this.
Hey there, I would really appreciate this getting in asap. The latest version makes Scout + Typesense unusable with "large" datasets over 500 items. First time trying Scout & this makes onboarding really hard.
The previous version or applying this fix works as expected.
@stammbach feel free to send in another PR that we can merge in faster.
@driesvints I've included the fix in one of my PRs becuase I touched that line anyway. Not sure if this makes anything faster but would really appreciate you checking it out.
@taylorotwell I apologise for taking too long to fix this, I've committed a fix to the variable name.
@AbdullahFaqeir Taylor doesn't sees draft PR's. Please mark this as ready if you need another review.
Fixing an issue caused import command or any other process that deals with the collection to recreate the collection as the exists flags wasn't updated properly.
Related Issue Other Related Issue Previous PR