search

laravel / scout

Laravel Scout provides a driver based solution to searching your Eloquent models.
https://laravel.com/docs/scout
MIT License
1.54k stars 327 forks source link

Fixing issue 825 #826

Closed AbdullahFaqeir closed 4 months ago

AbdullahFaqeir commented 4 months ago

Fixing an issue caused import command or any other process that deals with the collection to recreate the collection as the exists flags wasn't updated properly.

Related Issue Other Related Issue Previous PR

driesvints commented 4 months ago

I'd give much more detailed info here for Taylor to review. Otherwise it won't be clear why this is needed.

taylorotwell commented 4 months ago

But now the method says it returns a Collection in the docblock but actually returns an index?

AbdullahFaqeir commented 4 months ago

But now the method says it returns a Collection in the docblock but actually returns an index?

I apologise as this is a mess-naming for the variable, will make sure to fix this.

stammbach commented 4 months ago

Hey there, I would really appreciate this getting in asap. The latest version makes Scout + Typesense unusable with "large" datasets over 500 items. First time trying Scout & this makes onboarding really hard.

The previous version or applying this fix works as expected.

driesvints commented 4 months ago

@stammbach feel free to send in another PR that we can merge in faster.

stammbach commented 4 months ago

@driesvints I've included the fix in one of my PRs becuase I touched that line anyway. Not sure if this makes anything faster but would really appreciate you checking it out.

AbdullahFaqeir commented 4 months ago

@taylorotwell I apologise for taking too long to fix this, I've committed a fix to the variable name.

driesvints commented 4 months ago

@AbdullahFaqeir Taylor doesn't sees draft PR's. Please mark this as ready if you need another review.