search

laravel / scout

Laravel Scout provides a driver based solution to searching your Eloquent models.
https://laravel.com/docs/scout
MIT License
1.54k stars 327 forks source link

Removed numericFilters from AlgoliaEngine. #837

Closed Boorinio closed 2 months ago

Boorinio commented 2 months ago

Hopefully fixes https://github.com/laravel/scout/issues/831 @driesvints

taylorotwell commented 2 months ago

The docs say where is for numeric equality checks.

Boorinio commented 2 months ago

The docs say where is for numeric equality checks.

Indeed, which is inconsistent with how meilisearch works (which supports everything). The docs also mention this

$orders = Order::search('Star Trek')->whereIn(
    'status', ['open', 'paid']
)->get();

Which currently doesn't work

driesvints commented 2 months ago

@taylorotwell there is indeed a deeper underlying issue here with inconsistency between drivers. I feel like we have an opportunity here to align the different drivers more and at the same time make the Algolia search more powerful. Could we reconsider?

taylorotwell commented 2 months ago

I guess we'll give it a shot. Will have to roll it back if it breaks something.

taylorotwell commented 2 months ago

@driesvints we need to test this on a real Laravel application before it can be released.

Boorinio commented 2 months ago

I guess we'll give it a shot. Will have to roll it back if it breaks something.

Thanks for merging this, if it does break something you can comment here, I will be happy to do a follow up!

driesvints commented 2 months ago

@Boorinio unfortunately we had to revert this one as it's incompatible with https://github.com/algolia/scout-extended which still expects numericFilters. Can you re-attempt the PR to 11.x and also add an entry to the upgrade guide?