Unable to disable link and media unfurling

laravel / slack-notification-channel

Slack Notification Channel for laravel.

https://laravel.com/docs/notifications#slack-notifications

MIT License

865 stars 59 forks source link

Unable to disable link and media unfurling #30

Closed larssonwassen closed 4 years ago

larssonwassen commented 4 years ago

Slack Notification Channel Version: 2.0.2
Laravel Version: 6.0.3
PHP Version: 7.2.26
Database Driver & Version:

Description:

Disabling link unfurling in slack messages does not work. Optional paramters with value of false gets dropped by array_filter when building json payload in SlackWebhookChannel. Slack ignores string values for unfurl_media and unfurl_links.

Steps To Reproduce:

Create new SlackMessage with a full valid url, set unfurlLinks(false), notify slack channel.

driesvints commented 4 years ago

Please provide code examples.