search

laravel / slack-notification-channel

Slack Notification Channel for laravel.
https://laravel.com/docs/notifications#slack-notifications
MIT License
869 stars 61 forks source link

[2.x] Fix method naming #47

Closed driesvints closed 3 years ago

driesvints commented 3 years ago

This PR clarifies the use of the timestamp method which now incorrectly says it'll set the actual timestamp. In fact, either a DateTime, DateInterval or a given number of delayed seconds until the attachment can be set should be passed.

taylorotwell commented 3 years ago

Why renamed to delay? I see in the Slack docs they indicate this timestamp is only used to display what time the attachment is related to.

image

driesvints commented 3 years ago

Hah, I misunderstood that. To be fair I think the availableAt call should be removed but that would be a breaking change.

I tried rephrasing the comment as best as I could to clarify what the method does but open to ideas on how to improve it.