laravel / slack-notification-channel

Slack Notification Channel for laravel.
https://laravel.com/docs/notifications#slack-notifications
MIT License
869 stars 61 forks source link

Fix PHPDoc type annotations #48

Closed alies-dev closed 3 years ago

alies-dev commented 3 years ago

Both SlackMessage::unfurlLinks and SlackMessage::unfurlMedia have boolean types, but PHPDoc for their setters use string type.

Additionally, I've changed arg names to keep them in sync with property names (the main problem was invalid arg name: public function unfurlMedia($unfurl)).

PS: a note about arguments renaming: image