search

laravel / slack-notification-channel

Slack Notification Channel for laravel.
https://laravel.com/docs/notifications#slack-notifications
MIT License
864 stars 59 forks source link

feat: Handle retry-after for slack notification channel #72

Closed ImJustToNy closed 1 year ago

ImJustToNy commented 1 year ago

Sometimes webhook rate limits. I think it should be handled in a better way, as per slack docs, by releasing job back onto the queue.

taylorotwell commented 1 year ago

You can just put a public $tries = 3 property on your notification class.

ImJustToNy commented 1 year ago

You can just put a public $tries = 3 property on your notification class.

Yes, it is possible, however i believe that it would be better to retry after certain amount of time, rather than just spamming the endpoint.