search

laravel / socialite

Laravel wrapper around OAuth 1 & OAuth 2 libraries.
https://laravel.com/docs/socialite
MIT License
5.58k stars 940 forks source link

Slack does not accept app directory submissions using the legacy `identity.avatar`,`identity.basic`, `identity.email` and `identity.team` scopes #702

Closed maartenpaauw closed 6 months ago

maartenpaauw commented 6 months ago

Socialite Version

5.13.2

Laravel Version

11.2.0

PHP Version

8.3

Database Driver & Version

MySQL 8

Description

The Slack provider requests the scopes identity.basic, identity.email, identity.team and identity.avatar, which are marked as outdated. This means developers cannot register new Slack applications, because the following automated feedback is provided, which blocks the developer for submitting their new application to the Slack app directory.

Outdated scopes

Slack suggests to use OpenID instead.

This scope is part of an outdated approach to Sign in with Slack. Apps using the Legacy Sign in with Slack protocol can no longer be created, and existing apps using this scope cannot be added to the App directory. We recommend using the modern Sign in with Slack protocol instead.

See https://api.slack.com/authentication/sign-in-with-slack for more information.

Steps To Reproduce

Submit an app to the Slack app directory using the scopes identity.avatar,identity.basic, identity.email and identity.team and see the error message.

maartenpaauw commented 6 months ago

I think a similar solution as the LinkedIn OpenID provider needs to be added?

https://github.com/laravel/socialite/pull/662

maartenpaauw commented 6 months ago

I've managed to create an open id provider implementation. I'll cleanup the code a bit and open up a pull request later this week.

driesvints commented 6 months ago

Thanks @maartenpaauw. It indeed seems we need a similar solution like the LinkedIn one if we're gonna do this on the current major release. We'd love to have a PR for this!

github-actions[bot] commented 6 months ago

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!