search

laravel / telescope

An elegant debug assistant for the Laravel framework.
https://laravel.com/docs/telescope
MIT License
4.77k stars 560 forks source link

Search HTTP Request Content: Enables pinpointing requests with specific data #1451

Closed abuzer closed 3 months ago

abuzer commented 3 months ago

Description: I'm thrilled to propose a new feature for Laravel Telescope: the ability to search the content of HTTP requests. This feature is aimed at enhancing the debugging capabilities of Telescope by allowing developers to locate specific requests based on their content.

Key Highlights: Search HTTP Request Content: Enables pinpointing requests with specific data. Seamless UI Integration: Maintains the intuitive experience of Telescope. Optimized for Performance: Designed to be efficient and minimally impactful on performance.

Why This Feature? As a Laravel developer, I've often faced the challenge of finding specific requests among many. This feature was born out of the necessity to streamline this process, making our lives a bit easier and our debugging faster.

My Journey & Request for Guidance: This is my first attempt at contributing to an open-source project. I am fully aware that there may be room for improvement and I am eager to learn from the community. Your feedback will not only help enhance this feature but also aid in my growth as a developer. I am open to suggestions and committed to making the necessary adjustments to meet the project's standards.

Closing Thoughts: I believe this feature will make Laravel Telescope an even more powerful tool for developers. I'm looking forward to your constructive feedback and hope to contribute positively to this amazing community.

Thank you for considering my contribution.

image_2024_03_27T08_16_56_802Z image_2024_03_27T08_17_01_763Z

driesvints commented 3 months ago

Thanks @abuzer. Can you undo some of the styling changes in this PR so we can focus on the actual changes involved?

abuzer commented 3 months ago

@driesvints There is not style changes, just a text field added? Are you referring to it?

abuzer commented 3 months ago

Updated.

taylorotwell commented 3 months ago

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

abuzer commented 3 months ago

@taylorotwell This is a great package. Plus I have checked this has been PR-ed multiple time. So there is a need of it. There is no much code involved in it, but we have had multiple time need for this search feature to filter down the request.

Lets say a request was logged 8 hours ago. For now we have to scroll down to almost 20 pages to find that request. Which is not efficient. Plus this function only works when there is a search query. Else the original code keeps on working as is.

Can you please reconsider it?

driesvints commented 3 months ago

@abuzer seems for now we have no plans for this, sorry. You can always fork Horizon if you want.