search

laravel / telescope

An elegant debug assistant for the Laravel framework.
https://laravel.com/docs/telescope
MIT License
4.84k stars 577 forks source link

Add crossorigin anonymus to the mix configuration because it's not possible to use with a CDN for all the resources #1468 #1470

Closed dantes4ur closed 5 months ago

dantes4ur commented 5 months ago

Fixing #1468 and this is a small fix to enable the telescope to serve from CDN, very useful for distributing public folder into S3/Cloudfront

taylorotwell commented 5 months ago

A comment on that issue says you just need to update?

dantes4ur commented 5 months ago

A comment on that issue says you just need to update?

Hey Taylor! Big fan of your work right here.

Found another error around Vite, discussing on the issue I opened

jason-nabooki commented 5 months ago

I don't think this is required since 5.0.2 was reverted? We're serving our telescope assets (5.0.3) from a CDN (Cloudfront) just fine without the attribute.

We did, however, run into issues with 5.0.2 when there was an integrity attribute added (https://github.com/laravel/telescope/pull/1461). The crossorigin="anonymous" would have helped there but for 5.0.3 there shouldn't be any issues?

dantes4ur commented 5 months ago

I don't think this is required since 5.0.2 was reverted? We're serving our telescope assets (5.0.3) from a CDN (Cloudfront) just fine without the attribute.

We did, however, run into issues with 5.0.2 when there was an integrity attribute added (#1461). The crossorigin="anonymous" would have helped there but for 5.0.3 there shouldn't be any issues?

As I pointed out here https://github.com/laravel/telescope/issues/1468#issuecomment-2062914816 I found issues with Vite on version 5.0.3, what would be a workaround?