search

laravel / telescope

An elegant debug assistant for the Laravel framework.
https://laravel.com/docs/telescope
MIT License
4.77k stars 560 forks source link

[5.x] Enhance query preview when using the pgsql driver #1486

Closed morloderex closed 3 weeks ago

morloderex commented 3 weeks ago

This is an attempt to fix the rendering issue that was reported in #1435

It does it by simply using the laravel framework build-in sql formatting logic if the laravel version is above 10.x. And appending the driver name to telescope content so that the sql-formatting javascript formatting library can format it in the correct dialect, while still falling back to use default of sql if it is not present.

I have also updated the javascript highlighter to it's own component in order to detect the correct dialect for psgql to take place.

However there is a breaking change with doing it in this way due to the framework's build-in sql formatting logic doesn't support named bindings. But given that framework's query builder itself only supports ? parameters anyway i don't really see that as a huge issue.

driesvints commented 2 weeks ago

Thanks for this PR @morloderex!