[2.x] Updated actions config

laravel / tinker

Powerful REPL for the Laravel framework.

https://laravel.com/docs/artisan#tinker

MIT License

7.34k stars 130 forks source link

[2.x] Updated actions config #108

Closed GrahamCampbell closed 4 years ago

GrahamCampbell commented 4 years ago

To be the same as the framework repos.

driesvints commented 4 years ago

I think it's best that we wait until a stable composer 2 version lands and becomes the new default. Otherwise we'll be update all repos again soon to remove the "2" indicator. Tests are running fast enough for now.

GrahamCampbell commented 4 years ago

I think it's best that we wait until a stable composer 2 version lands and becomes the new default. Otherwise we'll be update all repos again soon to remove the "2" indicator. Tests are running fast enough for now.

Actually, the tests will break when composer 2 becomes the default (because of the changes needed to the install step), so this PR is a proactive fix.

driesvints commented 4 years ago

@GrahamCampbell so composer 2 will break all apps/servers that auto update composer?

GrahamCampbell commented 4 years ago

No. Most apps don't do a require without there already being a lock file present. That is what is not supported. You must ask for either no-update, or already have a lock file.

GrahamCampbell commented 4 years ago

What I am talking about is this:

driesvints commented 4 years ago

Gotcha. I'll try to look into this some more next week.

GrahamCampbell commented 4 years ago

Perfect. :)