search

laravel / tinker

Powerful REPL for the Laravel framework.
https://laravel.com/docs/artisan#tinker
MIT License
7.34k stars 130 forks source link

Commands inside tinker incorrectly parsed #141

Closed amadeann closed 2 years ago

amadeann commented 2 years ago

Steps To Reproduce:

  1. Open psysh
  2. type exit

Expected: Tinker closes with Exit: Goodbye Actual: RuntimeException with message 'Too many arguments, expected arguments "command".'

From what I see, it most likely caused by the change in symfony/console (line 27) commited 10 days ago: https://github.com/symfony/console/commit/aa58a696655593b0a012166cfbcf34fafac6e945

Because of that change Psy\Input\ShellInput::tokenize() is not able to correctly parse arguments. Instead of catching the entire "exit" string, it parses it letter by letter.

amadeann commented 2 years ago

Posted it here by mistake (I initially thought it was a bug in tinker). See the issue for reference: https://github.com/bobthecow/psysh/issues/704