search

laravel / tinker

Powerful REPL for the Laravel framework.
https://laravel.com/docs/artisan#tinker
MIT License
7.34k stars 130 forks source link

[2.x] Improves console output #152

Closed nunomaduro closed 2 years ago

nunomaduro commented 2 years ago

This pull request improves the output of tinker without breaking changes. Meaning that once merged, this pull request will be available even for Laravel 6 applications.

So, regarding the changes, here is some examples, the before vs after:

Screenshot 2022-07-27 at 14 00 01 Screenshot 2022-07-27 at 14 04 34 Screenshot 2022-07-27 at 14 07 00
Wirone commented 2 years ago

image

I understand UI improvements and the need to get good-looking output, but removing credits from the original tool that runs Tinker is unfortunate, at least. Tinker's repo contains 4 (FOUR) actual classes, the whole "fancy magic" is handled by PsySH which is on MIT licence - not only Laravel Tinker does not mention in any way that it's built on top of PsySH, it also now hides such info when running command. Personally, I find it really rude. This is not the way how you appreciate other people's work 😕

nunomaduro commented 2 years ago

@bobthecow Are you ok on having us removing the header from tinker? If not, we don't mind of adding it back.

nunomaduro commented 2 years ago

@bobthecow Pull requesting this tomorrow to https://github.com/bobthecow/psysh.